openchannel: allow creating channels with connected peers without an address #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
reviewed
Feb 25, 2025
Contributor
|
Please squash the fixup commit and then I think we can land this. |
…address openchannel now supports both `pubkey@host:port` and `pubkey` as arguments. If only `pubkey` is provided, a channel is created only if the peer is already connected; otherwise, an error is returned.
Psycho-Pirate
force-pushed
the
openchannel_parser
branch
from
b464db3 to
438f2a7
Compare
Contributor
Author
|
I have squashed the commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openchannel now supports both
pubkey@host:portandpubkeyas arguments. If onlypubkeyis provided, a channel is created only if the peer is already connected; otherwise, an error is returned.